Closed
Bug 1324382
Opened 8 years ago
Closed 8 years ago
Update mach to download clang-format 4.0
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(4 files)
Now that clang-format 4.0 matches our coding style (see https://reviews.llvm.org/rL289660), we should update the mach code:
https://dxr.mozilla.org/mozilla-central/source/tools/mach_commands.py#225
to download the latest version of clang format.
|
||
Comment 1•8 years ago
|
||
This is the binary for OS X
|
|
||
Comment 2•8 years ago
|
||
win64 binary
|
Assignee | |
Comment 3•8 years ago
|
||
linux now
|
|
Assignee | |
Comment 4•8 years ago
|
||
Built using
make -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ../
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8819886 [details]
Bug 1324382 - Update mach to download clang-format 4.0
https://reviewboard.mozilla.org/r/99520/#review100754
I trust you to not have uploaded malicious binaries.
The build system will soon require libclang to compile C++. Hopefully we can start using `clang-format` from official sources soon.
If you anticipate this "download Clang binary" thing living much longer, we should change the hosting to tooltool. See https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool#How_To_Upload_To_Tooltool
Attachment #8819886 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
> I trust you to not have uploaded malicious binaries.
No, just some bitcoin mining ;)
I will have a look to tooltool. Thanks!
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sledru
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac71e73d904d
Update mach to download clang-format 4.0 r=gps
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•